Skip to content

chore(ci): fix post release workflow #1638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 29, 2023
Merged

Conversation

dreamorosi
Copy link
Contributor

Description of your changes

As detailed in the linked issue, the post release workflow was not working as intended. Due to this, the comment that was left under the issues related to a release did not include the correct release number. This caused the maintainers to have to manually fix all the comments after each release.

This PR introduces a new step to the post-release workflow that checks the presence of the release version, and if it's not present in the inputs (which is the case when the workflow is triggered by a release), it retrieves it from the latest git tag.

This should fix the workflow and make it so that the comments are correct.

Related issues, RFCs

Issue number: closes #1493

Checklist

  • My changes meet the tenets criteria
  • I have performed a self-review of my own code
  • I have commented my code where necessary, particularly in areas that should be flagged with a TODO, or hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my change is effective and works
  • The PR title follows the conventional commit semantics

Breaking change checklist

Is it a breaking change?: NO

  • I have documented the migration process
  • I have added, implemented necessary warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@dreamorosi dreamorosi self-assigned this Jul 29, 2023
@dreamorosi dreamorosi requested a review from a team July 29, 2023 12:26
@boring-cyborg boring-cyborg bot added the automation This item relates to automation label Jul 29, 2023
@pull-request-size pull-request-size bot added the size/XS PR between 0-9 LOC label Jul 29, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@dreamorosi dreamorosi merged commit ca40c46 into main Jul 29, 2023
@dreamorosi dreamorosi deleted the chore/fix-post-release branch July 29, 2023 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation This item relates to automation size/XS PR between 0-9 LOC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maintenance: fix post-release workflow
1 participant